ReactiveX / RxCpp

Reactive Extensions for C++
Apache License 2.0
3.07k stars 396 forks source link

unqualified `ptrdiff_t` & `size_t` use #164

Closed MattPD closed 9 years ago

MattPD commented 9 years ago

Is this intentional?

As of GCC 4.9 this is no longer supported (and it was never std. compliant) -- see "Header changes": https://gcc.gnu.org/gcc-4.9/porting_to.html // Edit: this appears to refer to the header inclusion missing entirely.

Currently #include <cstddef> is used in two places:

A fix would be to either:

I presume the choice may very well be a matter of preference :-)

kirkshoop commented 9 years ago

I would prefer explicit use of std::

I think there was variation across compilers and std libraries that caused the explicit std:: to fail. Any solution would need to pass travisci and appveyor :)

MattPD commented 9 years ago

OK, let's see if this passes! :-)

Edit: All checks have passed :-)

kirkshoop commented 9 years ago

Looks great!