search

ReactiveX / RxCpp

Reactive Extensions for C++
Apache License 2.0
3.07k stars 396 forks source link

New schedulers? #183

Closed windoze closed 8 years ago

windoze commented 8 years ago

I'm working on integration for RxCPP and Boost.ASIO as I think they are perfect match, a test scheduler using boost::asio::io_service can be found at https://gist.github.com/windoze/a6e684143833d5d65ba6 and more complete version is coming. Before submitting PR, I want to know:

  1. Does RxCPP accept 3rd-party dependencies?
  2. Where to put 3rd party dependent components?

Any suggestions?

daixtrose commented 8 years ago

I would say: a new projrct on GitHub

kirkshoop commented 8 years ago

Hi, this is great! can't wait to see this working!

rxcpp has a git-submodule dependency on the catch library. these are kept in the /ext/ dir

I would not keep a copy of dependencies in the rxcpp repo. I would also expect that the code would have tests that would run on travisci (linux, osx) and appveyor.

A couple of ways to achieve this is conan.io and biicode. the biicode company has shutdown, so conan.io would be good to try out.

I agree with @daixtrose that this seems like it deserves its own repo. I could create one under ReactiveX org and give you access, if you like. What name would you prefer? Perhaps rxcpp-boost or rxcpp-asio

The repos would be attached by git submodules. for instance, rxcpp-boost would have rxcpp as a git submodule.

kirkshoop commented 8 years ago

closing due to inactivity