search

ReactiveX / RxCpp

Reactive Extensions for C++
Apache License 2.0
3.05k stars 395 forks source link

Fix '-Wignored-qualifiers' #441

Closed besser82 closed 6 years ago

besser82 commented 6 years ago

Fix -Wignored-qualifiers in rx-subscription.hpp:

/rpmbuild/BUILD/RxCpp-4.0.0/Rx/v2/src/rxcpp/rx-subscription.hpp: In constructor 'rxcpp::composite_subscription::composite_subscription()':
/rpmbuild/BUILD/RxCpp-4.0.0/Rx/v2/src/rxcpp/rx-subscription.hpp:382:66: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
         , subscription(*static_cast<const inner_type* const>(this))
                                                                  ^

This is reproduceble with gcc-8.0.1 on Fedora 28:

gcc (GCC) 8.0.1 20180324 (Red Hat 8.0.1-0.20)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
kirkshoop commented 6 years ago

This is great! - I am dealing with some access issues at the moment, I will merge once everything is working again.