cmake: Fix 'make' generator targets

ReactiveX / RxCpp

Reactive Extensions for C++

Apache License 2.0

3.05k stars 395 forks source link

cmake: Fix 'make' generator targets #480

Closed iam closed 5 years ago

iam commented 5 years ago

Remove 'RxCpp' library target when it's used outside of Visual Studio. This was supposed to be a virtual target, not an actual one that builds libRxCpp.so.

The build never worked because it was missing setting the compiler/linker flags from shared.cmake

Resolves: #477

iam commented 5 years ago

Maybe flake? Didn't see this CI failure on other PRs.

E: Unable to locate package g++-4.9
E: Couldn't find any package by glob 'g++-4.9'
E: Couldn't find any package by regex 'g++-4.9'

kirkshoop commented 5 years ago

Yes, that was a flakey build. Thanks!