ReactiveX / RxJava

RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.
Apache License 2.0
47.88k stars 7.61k forks source link

Update wiki to reflect 3.x (tracking issue) #6132

Open akarnokd opened 6 years ago

akarnokd commented 6 years ago

This is the overview of the suggested/planned changes to the Wiki. Text in bold are for extra considerations/options.

khkong commented 5 years ago

@akarnokd An invalid link was found in the Additional-Reading.md file. Can I merge request a partial update?

MorrisLaw commented 4 years ago

Maybe you can start picking up these tasks to get familiar with making PRs to this repo @ddunig2

ddunig2 commented 4 years ago

@akarnokd may I help contribute to this project?

akarnokd commented 4 years ago

@ddunig2 Sure.

ddunig2 commented 4 years ago

@akarnokd im not sure if this issue is closed or not but I am fairly new to GitHub contribution. If this happens to be closed, whats a good first issue on this project?

akarnokd commented 4 years ago

Closed issues have a big red button indicating as such:

image

Otherwise, we don't have any good first issues at the moment. However, you could try and backport #6729 to the RxJava 2.x branch. Please consult a Git/Github tutorial if you don't know how to do things.

ddunig2 commented 4 years ago

@akarnokd Im somewhat familiar with GitHub. By backport do you mean committing the fixes in #6729 to the 2.x branch?

akarnokd commented 4 years ago

You'd have to manually apply the changes in the source code of the 2.x branch as the files and locations do not match for an automatic backport.

ddunig2 commented 4 years ago

@akarnokd I'm having trouble getting the project on my local machine without any errors. I forked and download it and wanted to make the changes on the eclipse IDE. Any idea why that may be?

akarnokd commented 4 years ago

What are those errors? Which Eclipse version are you using?

ddunig2 commented 4 years ago

@akarnokd Im using Eclipse-java 2019-09, java jdk13. The i just recloned it to check the issue and atm has no issue warning but when I run .\gradlew build, it fails

FAILURE: Build failed with an exception.

akarnokd commented 4 years ago

Install a Jdk 8 runtime and have Eclipse use it as a target:

image

ddunig2 commented 4 years ago

@akarnokd of great, I don't notice any errors. Now, I am on the 3x branch, Im not too familiar with backporting, would you be able to give me a quick guide as to what happens from here? So you mentioned that i would have to manually change the source code in the 2x branch to match the 3x branch, Can I get a little more detail. Am I changing the whole code or am I looking at a specific package?

akarnokd commented 4 years ago

No.

  1. Check out the 2.x branch
  2. Create a new branch of of 2.x named JavadocCleanup_1203
  3. Open the changed files of #6729 in a browser
  4. For each file, expand the sections until you see the method name. For the first entry, it is public final Single<Long> count() {
  5. Locate this file and method in your IDE
  6. Apply the changes you see on the web page: remove lines or add lines
  7. Once done, make sure you have your own fork as remote in the Git repositories view under RxJava
  8. Add a commit message and commit the changes, and then push to your fork.
  9. Go to the PR page and wait for your branch to pop up to make a PR
  10. Make a PR and fill in some explanation about what you've done.
ddunig2 commented 4 years ago

@akarnokd thank you that was fairly descriptive. The first change I see is the removal of the @see #count but nothing in the method itself. Is that what you are referring to? pic

ddunig2 commented 4 years ago

@akarnokd I made a PR!

VovaStelmashchuk commented 4 years ago

Doc https://github.com/ReactiveX/RxJava/blob/2.x/docs/Filtering-Observables.md, Looks like up to date. Can you put checkmark?

skywall commented 4 years ago

https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#blockingstream Currently defined as: [Empty]() Flowable, [Empty]() Observable, [New]() Maybe, [New]() Single, [New]() Completable

But this should be: [New]() Flowable, [New]() Observable, [Empty]() Maybe, [Empty]() Single, [Empty]() Completable

akarnokd commented 4 years ago

@skywall Updated.

mghildiy commented 3 years ago

I would like to work on it.

aleedy commented 3 years ago

Looking to do a little a little contribution since I'm back working on a project using RxJava. Would checking some of these off be the best place to start?

akarnokd commented 3 years ago

These two could use the restyling: