search

ReactiveX / RxJavaFX

RxJava bindings for JavaFX
Apache License 2.0
519 stars 67 forks source link

BindingObserver and BindingSubscriber mustn't use com.sun* classes #68

Closed protogenes closed 6 years ago

protogenes commented 6 years ago

The usage of internal com.sun classes breaks on newer Java versions.

./src/main/java/io/reactivex/rxjavafx/observers/BindingObserver.java import com.sun.javafx.binding.ExpressionHelper; ./src/main/java/io/reactivex/rxjavafx/observers/BindingSubscriber.java import com.sun.javafx.binding.ExpressionHelper;

thomasnield commented 6 years ago

Which version(s) is it breaking on? I'm a bit behind and stayed on Java 8, waiting for decoupling to happen with Java 11.

protogenes commented 6 years ago

It is breaking with OpenJDK+OpenJFX 11-ea25 At work we are currently stuck on 8u92 because of changes in later updates that break things. With the upcoming release of version 11 in two weeks I wanted to check what dependencies are missing out and preventing an early update as I want to skip 9 and 10 completely.

thomasnield commented 6 years ago

@protogenes that's my strategy as well. I'll follow up shortly

thomasnield commented 6 years ago

Resolved.