ReactiveX / RxJavaFX

RxJava bindings for JavaFX
Apache License 2.0
519 stars 67 forks source link

Java 11 Automatic-Module-Name #74

Closed claudio-rosati closed 5 years ago

claudio-rosati commented 6 years ago

RxJava added Automatic-Module-Name: io.reactivex.rxjava2 to the manifest, in order to have a small step into the Java 11 full module transition. This was in the following clause of the build.graddle file:

jar {
    manifest {
        name = "rxjava"
        instruction "Bundle-Vendor", "RxJava Contributors"
        instruction "Bundle-DocURL", "https://github.com/ReactiveX/RxJava"
        instruction "Import-Package", "!org.junit,!junit.framework,!org.mockito.*,!org.testng.*,*"
        instruction "Eclipse-ExtensibleAPI", "true"
        instruction "Automatic-Module-Name", "io.reactivex.rxjava2"
    }
}

Can this be made also for RxJavaFX?

thomasnield commented 6 years ago

I'll take a look. First I need to get the current codebase deployed for Java 11 which I have been having challenges with.

claudio-rosati commented 6 years ago

Thank you