search

ReactiveX / RxPY

ReactiveX for Python
https://rxpy.rtfd.io
MIT License
4.72k stars 356 forks source link

Allow any python in the 3.x series >=3.7 #656

Closed mmv closed 2 years ago

mmv commented 2 years ago

Before converting from setup.py to pyproject, this upper bound didn't exist.

There's no reason to cap at 3.10. This breaks installations on other poetry projects defined with Python=^3.7 and would force updating this file for every new python version.

dbrattli commented 2 years ago

Instead of this I suggest that you change python-package.yaml to test specifically for a higher python version e.g 3.11.0-beta.4 so we know if it actually works or not. See https://github.com/actions/python-versions. Then we can change pyproject.toml to also include 3.11.

dbrattli commented 2 years ago

This makes me unsure if we should accept every new minor version: https://stackoverflow.com/questions/60421663/is-python-3-semantically-versioned-and-forwards-compatible. But I understand the frustration of not being able to use it if it actually works. Parts of me want to approve this PR 😄

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 93.375% when pulling 696fbc63b2eb0bd2e760855ed50de539f1a17373 on mmv:patch-1 into 4d351c9591d9a039bca2de89ec92ec42a18c0c08 on ReactiveX:master.

MainRo commented 2 years ago

Thanks @dbrattli ! I also felt this restriction was... too restrictive.