search

ReactiveX / RxPY

ReactiveX for Python
https://rxpy.rtfd.io
MIT License
4.77k stars 361 forks source link

Fix collections imports for Python 3.10+ #668

Closed benhiller closed 1 year ago

benhiller commented 1 year ago

Right now RxPY 1.6.1 imports Iterable from collections, which is deprecated and will break in Python 3.10. The recommended way of doing this now is importing Iterable from collections.abc. This is a PR for the release/v1.6.x branch which fixes that (in a backwards compatible way), so that projects stuck with RxPY 1.6.x can still upgrade to Python 3.10. My hope is that this can be released as a new minor version (probably 1.6.2) of RxPY.

For context on why this is worth sending out a PR for: we have a project that depends on RxPY via another dependency. Unfortunately, that dependency only supports RxPY <2, and upgrading that seems non-trivial, so it seems easier to fix this 3.10 issue in RxPY.

This PR also includes a commit that bumps the version, but I can remove that if it would simplify things! I know that submitting a PR to the release/v1.6.x branch is a bit odd, let me know if there is a better way of going about this.

Test Plan: I ran python -m unittest discover tests before and after this change with both Python 3.9 and Python 2.7. I confirmed the number of tests passed before and after this change was the same (though with 2.7 there were 17 errors even before this change, and with 3.9 there were 17 errors and 5 failures even before this change. Not sure if that is due to any configuration issues on my end).

benhiller commented 1 year ago

@dbrattli , would you be the right person to review this? If you could take a look that would be amazing!

MainRo commented 1 year ago

I would favor pushing this change and publishing a new maintenance release. That's a small change.

dbrattli commented 1 year ago

@MainRo How should we make the release? Upload manually? Do you want to take care of this?

MainRo commented 1 year ago

yes, we can add a new tag and then release it manually. I will look at it. We can proceed the same way for - eventual - v2 fixes.

MainRo commented 1 year ago

Rx 1.6.3 is published on PyPi

benhiller commented 1 year ago

Awesome, thank you so much!