search

ReactiveX / RxPY

ReactiveX for Python
https://rxpy.rtfd.io
MIT License
4.81k stars 361 forks source link

Some operators revamped with curry flip #689

Open matiboy opened 1 year ago

matiboy commented 1 year ago

Additionally

  1. Typed run's return to T_out not Any
  2. Removed average's never hit check for count == 0 (take_last operator already raises) and fixed corresponding test
  3. Try to clarify all's behavior, specifically that it emits False and completes as soon as one item fails the predicate
coveralls commented 1 year ago

Coverage Status

Coverage: 93.44% (+0.03%) from 93.407% when pulling 8600ec21eaefc2d55910f4ba876d71936158e983 on matiboy:curry-flip into 15754e0e2000b9fc312e4b5536156bc29f1a06d4 on ReactiveX:curry-flip.

dbrattli commented 1 year ago

This is great 👍 One thing I just discovered is that PyCharm do not understand the curry_flip decorator. PyCharm is really bad with typing through decorators, so would we let that affect us or not?