Closed taher-mosbah closed 4 years ago
EricAppel
commented
4 years ago Here's a sample project using Swift Package Manager and RxSwift 5.1.1 that demonstrates the bug. We are not receiving values when subscribing to UISearchBar.rx.value and are experiencing a crash when providing our own delegate for text changes.
freak4pc
commented
4 years ago @EricAppel Thanks for the repro. For now i'd use text instead of value. I'll see if I can debug this.
freak4pc
commented
4 years ago I actually just ran your project and it works fine for me. That's really strange:
dimitris-c
commented
4 years ago I had a look at this one and it seems to be within the _RXDelegateProxy when collecting void selectors (collectVoidSelectorsForProtocol). While running on iOS the selectors for UISearchBarDelegate were showing up but not when running on Mac Catalyst. And with no call to forwardInvocation on _RXDelegateProxy means sentMessage and methodInvoked will never be called.
I've also run a few other delegate methods like this UITabBarController().rx.delegate.methodInvoked(...).debug().subscribe() to trigger the initialisation of _RXDelegateProxy and it seems the UISearchBar is the only one that's not cooperating...
So maybe this is a Mac Catalyst issue?! not sure...
tsabend
commented
4 years ago @freak4pc did u run for catalyst? that screenshot looks like iOS and the bug only appears on catalyst.
taher-mosbah
commented
4 years ago @dimitris-c did you see any workarounds maybe ?
freak4pc
commented
4 years ago Sorry about the confusion. This definitely seems like an issue in Catalyst worth reporting, but I'm not sure where it stems from.
Even the raw version of this doesnt work:
searchBar.rx
.delegate
.methodInvoked(#selector(UISearchBarDelegate.searchBar(_:textDidChange:)))Also, this is specific to UISearchBar, because even when trying other DelegateProxy-using constructs (like NSTextViewStorage, e.g. UITextView) it seems to work just fine even in Catalylst.
dimitris-c
commented
4 years ago @freak4pc this seems to be an issue with Catalyst, you can read my previous answer to see my findings.
tsabend
commented
4 years ago I'm happy to write or help promote a radar, but I'm not quite sure what the Catalyst issue is.
dimitris-c
commented
4 years ago Created a small snippet that can be used to see the issue. On Catalyst the objc runtime doesn't seem to pick up the search bar delegate method, changing the UISearchBarDelegate to another delegate prints its declared methods.
#import <Foundation/Foundation.h>
NS_ASSUME_NONNULL_BEGIN
@interface CatalystIssueOnUISearchBar : NSObject
@end
NS_ASSUME_NONNULL_ENDCatalystIssueOnUISearchBar.m class
#import "CatalystIssueOnUISearchBar.h"
#import <objc/runtime.h>
#import <UIKit/UIKit.h>
@interface Delegate : NSObject<UISearchBarDelegate>
@end
@implementation Delegate
@end
@implementation CatalystIssueOnUISearchBar
- (instancetype)init
{
self = [super init];
if (self) {
Class targetClass = Delegate.class;
unsigned int count;
Protocol *__unsafe_unretained *protocols = class_copyProtocolList(targetClass, &count);
for (unsigned int i = 0; i < count; i++) {
unsigned int protocolMethodCount = 0;
struct objc_method_description *pMethods = protocol_copyMethodDescriptionList(protocols[i], NO, YES, &protocolMethodCount);
for (unsigned int i = 0; i < protocolMethodCount; ++i) {
struct objc_method_description method = pMethods[i];
NSLog(@"%@", NSStringFromSelector(method.name));
}
free(pMethods);
}
free(protocols);
}
return self;
}
@end
Thanks for that @dimitris-c. I made a little swift project that replicates based on that snippet CatalystProtcolBug.zip
and filed a radar with apple: FB7710557
freak4pc
commented
4 years ago @tsabend thank you so much ! Would it be worth to also file on bugs.swift.org ?
freak4pc
commented
4 years ago I'm going to close this one or now. Even though it's a good reference, unfortunately there's nothing we can do to fix it without Apple's help.
Short description of the issue:
RxSearchBarDelegateProxy not working on Catalyst.
Expected outcome: Delegate methods should work like on iOS as it is marked as available on Catalyst on Apple documentation.
What actually happens:
The app crashs with
unrecognized selector sent to instanceRxSwift/RxCocoa/RxBlocking/RxTest version/commit
RxSwift 5.5.1
Platform/Environment
How easy is to reproduce? (chances of successful reproduce after running the self contained code)
Xcode version:
Installation method:
I have multiple versions of Xcode installed: (so we can know if this is a potential cause of your issue)
Level of RxSwift knowledge: (this is so we can understand your level of knowledge and formulate the response in an appropriate manner)