Closed yudonlee closed 6 months ago
I believe this is a mistake in the documentation. The observable passed into take(until:)
will only terminate the source on an onNext or onError event, not for onCompleted.
This is also how the reference implementation for C# works.
I believe this is a mistake in the documentation. The observable passed into
take(until:)
will only terminate the source on an onNext or onError event, not for onCompleted.This is also how the reference implementation for C# works.
Thank you! I didn't think the document was wrong. But why doesn't the document change?
Exactly what file are you talking about with incorrect documentation? I invite you to submit a pull request with the file corrected.
The document I'm talking about is the official Reactive.io document.! https://reactivex.io/documentation/operators/takeuntil.html
I submitted a PR.
:warning: If you don't have something to report in the following format, it will probably be easier and faster to ask in the slack channel first. :warning:
:warning: Please take you time to fill in the fields below. If we aren't provided with this basic information about your issue we probably won't be able to help you and there won't be much we can do except to close the issue :( :warning:
If you still want to report issue, please delete above statements before submitting an issue.
Short description of the issue: Says
But if Second Observable terminates, Source observer still can emit the item. description here
Expected outcome:
What actually happens:
Self contained code example that reproduces the issue:
RxSwift/RxCocoa/RxBlocking/RxTest version/commit 6.0.0 version or commit here
Platform/Environment
How easy is to reproduce? (chances of successful reproduce after running the self contained code)
Xcode version:
:warning: Fields below are optional for general issues or in case those questions aren't related to your issue, but filling them out will increase the chances of getting your issue resolved. :warning:
Installation method:
I have multiple versions of Xcode installed: (so we can know if this is a potential cause of your issue)
Level of RxSwift knowledge: (this is so we can understand your level of knowledge and formulate the response in an appropriate manner)