search

ReactiveX / RxSwift

Reactive Programming in Swift
MIT License
24.37k stars 4.17k forks source link

Add fatal synchronization error hook #2506

Closed gabriellanata closed 6 months ago

gabriellanata commented 1 year ago

This change introduces a setting to trigger a fatal error when a synchronization error is detected. The FATAL_SYNCHRONIZATION flag has precedence over this setting and it does not change the current default behavior.

Reasoning: We're trying to work through many synchronization errors in our app, but this process is going to take a while. In the meantime, we want to prevent new errors from being added to places that don't have them already. Our approach is to enable this setting for tests and provide a way to disable it for specific tests that currently have synchronization issues. One of the things we need for this to be possible is a way to turn this feature on or off easily.

freak4pc commented 1 year ago

This change introduces a setting to trigger a fatal error when a synchronization error is detected. The FATAL_SYNCHRONIZATION flag has precedence over this setting and it does not change the current default behavior.

Reasoning: We're trying to work through many synchronization errors in our app, but this process is going to take a while. In the meantime, we want to prevent new errors from being added to places that don't have them already. Our approach is to enable this setting for tests and provide a way to disable it for specific tests that currently have synchronization issues. One of the things we need for this to be possible is a way to turn this feature on or off easily.

I'm sorry for not replying so far, I guess you have worked around this in a different way but I'm wondering what's the reaosn to not add FATAL_SYNCHRONIZATION to your test suite directly, instead of an additional flag from the RxSwift side?

freak4pc commented 6 months ago

No response, closing