search

ReactiveX / RxSwing

RxJava bindings for Swing
Apache License 2.0
98 stars 23 forks source link

List selection event support #25

Closed Petikoch closed 9 years ago

Petikoch commented 9 years ago

Best regards, Peti

Petikoch commented 9 years ago

Hi everyone, Hi @eddieburns55,

would be nice to get this in and bake a new RxSwing release... I'm waiting for the release of the recently merged WindowEventSource, too.

Best regards, Peti

epb-644 commented 9 years ago

Hi Peti, thanks for the PR. Sorry, I started a new job recently so it may take me a few days to review it. I'll try to cut a new release once we merge this ListSelection support in.

Petikoch commented 9 years ago

Hi @eddieburns55 ,

thanks for your feedback.

I wish you a good start in the new job!

Best regards from Switzerland, Peti

epb-644 commented 9 years ago

Please remove the underscores in method names in ListSelectionEventSourceTest. Otherwise, everything looks good.

Petikoch commented 9 years ago

Thanks @eddieburns55 for the review. I updated the pull request.

Best regards, Peti

Petikoch commented 9 years ago

@eddieburns55, when do you think the new release will be available? Best regards,Peti

epb-644 commented 9 years ago

Hi @Petikoch, I'll work on it this weekend. Thanks for reminding me. :)