search

ReactiveX / learnrx

A series of interactive exercises for learning Microsoft's Reactive Extensions Library for Javascript.
1.4k stars 292 forks source link

Fix problems with Exercise 37 #179

Closed seanpoulter closed 5 years ago

seanpoulter commented 5 years ago

Proposed changes

  1. Switch from forEach to do because forEach actually returns a Promise. When it resolved it would call showMovieLists with unexpected results.
  2. Change to the v5 callback names for onNext, onError, and onCompleted.
  3. Send a fake event to the load event listener to prevent a TypeError.
  4. Replace Object.create with [].concat to keep the elements of movieListsMessage.list int eh result.


Demo reactivex - learnrx - fixes 177

This PR will close issue #177.