search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

fix(operators): added tips after operator description #137

Closed btroncone closed 6 years ago

btroncone commented 6 years ago

Added tips to display after operator long description if they exist. Also removed parameter section if no parameters exist.

ladyleet commented 6 years ago

@sumitarora really appreciate you helping review PRs.

btroncone commented 6 years ago

Weird, looks like everything passed this time but something with selenium failed. Care to take a look @kwonoj?

codecov-io commented 6 years ago

Codecov Report

Merging #137 into master will increase coverage by 1.57%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   86.88%   88.46%   +1.57%     
==========================================
  Files           4        7       +3     
  Lines          61       78      +17     
  Branches        7        7              
==========================================
+ Hits           53       69      +16     
- Misses          5        6       +1     
  Partials        3        3
Impacted Files Coverage Δ
src/app/shared.module.ts 100% <100%> (ø)
src/app/app.component.ts 100% <100%> (ø) :arrow_up:
src/app/toolbar/toolbar.module.ts 100% <100%> (ø)
src/app/toolbar/toolbar.component.ts 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29af945...cc4bdf1. Read the comment docs.

kwonoj commented 6 years ago

It seems one time woes on travis.

btroncone commented 6 years ago

Can this be reviewed / merged? It fixes a couple of display issues on the operator page that may cause confusion to others checking their operator PR's. @ladyleet @kwonoj @sumitarora

sumitarora commented 6 years ago

@btroncone Please rebase with master.

ladyleet commented 6 years ago

@btroncone 👍 - waiting on @kwonoj or @ashwin-sureshkumar to review & merge.