ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4

Apache License 2.0

160 stars 62 forks source link

feature(companies) #142

Closed Only1MrAnderson closed 6 years ago

Only1MrAnderson commented 6 years ago

Adds firebase to the companies feature. Includes basic form for adding companies. Need to add more testing, adding logo and responsive form / layout.

Only1MrAnderson commented 6 years ago

10

ashwin-sureshkumar commented 6 years ago

@ladyleet @Only1MrAnderson - Is the feature for anyone to add companies or are we planning to have an approval process on what companies are listed on the docs site ?

ladyleet commented 6 years ago

We can skip the approval process

Only1MrAnderson commented 6 years ago

According to the last message we are skipping it

Sent from my iPhone

On Nov 15, 2017, at 1:35 PM, Tracy Lee notifications@github.com wrote:

We can skip the approval process

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ashwin-sureshkumar commented 6 years ago

@Only1MrAnderson @ladyleet - Thanks !

@Only1MrAnderson - The CI is failing, could you please address that.

ladyleet commented 6 years ago

@Only1MrAnderson can't wait to merge this one in!!!!!

sumitarora commented 6 years ago

@Only1MrAnderson Please rebase.

Only1MrAnderson commented 6 years ago

@sumitarora This pr is missing core functionality for this feature. I will update this shortly.

ladyleet commented 6 years ago

Thx @Only1MrAnderson !

codecov-io commented 6 years ago

Codecov Report

Merging #142 into master will decrease coverage by 1.09%. The diff coverage is 75%.

@@            Coverage Diff            @@
##           master     #142     +/-   ##
=========================================
- Coverage   85.71%   84.61%   -1.1%     
=========================================
  Files           8       10      +2     
  Lines          91      104     +13     
  Branches        4        4             
=========================================
+ Hits           78       88     +10     
- Misses         13       16      +3

Impacted Files	Coverage Δ
src/environments/environment.ts	`100% <ø> (ø)`
src/app/shared.module.ts	`100% <100%> (ø)`	:arrow_up:
src/app/companies/company.service.ts	`72.72% <72.72%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c16f79b...a247d14. Read the comment docs.

Only1MrAnderson commented 6 years ago

I am working on trying to resolve the MatDialog build error. Seems to be a known issue in the library testing entry components. For now, I commented that test out so I could publish the project and get feedback on everything else

rxjs-bot commented 6 years ago

	Fails
:no_entry_sign:	commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by :no_entry_sign: dangerJS

sumitarora commented 6 years ago

@ashwin-sureshkumar Can you resolve the conflicts?

ashwin-sureshkumar commented 6 years ago

@ladyleet @btroncone @sumitarora - Closing this PR since the origin branch doesn't exist anymore. I have submitted another PR with the update. https://github.com/ReactiveX/rxjs-docs/pull/222

ladyleet commented 6 years ago

closing this since andrew got busy and ashwin submitted another PR for this.