Closed nicolaisueper closed 6 years ago
Merging #149 into master will decrease coverage by
2.56%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 91.02% 88.46% -2.57%
==========================================
Files 7 7
Lines 78 78
Branches 5 7 +2
==========================================
- Hits 71 69 -2
Misses 6 6
- Partials 1 3 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/app/operators/operators.component.ts | 80.48% <0%> (-4.88%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d02c2fb...6f6ae8a. Read the comment docs.
Sorry for the commit message error, fixed it a minute ago.
thx @nicolaisueper! can you rebase pls?
@ladyleet done!
Sorry @nicolaisueper, can you please rebase once more.
@ashwin-sureshkumar There's only one commit inside this PR, I don't really know what I should do. Can you please explain to me how I should rebase?
This is (almost) the first foreign open source project I'm contributing to, so please excuse my start difficulties :)
Not a problem at all. Please follow below steps, I am being very explicit ignore if you have already done lot of these.
git remote -v
The above should two remote addresses
origin git@github.com:nicolaisueper/rxjs-docs.git (fetch)
origin git@github.com:nicolaisueper/rxjs-docs.git (push)
upstream git@github.com:ReactiveX/rxjs-docs.git (fetch)
upstream git@github.com:ReactiveX/rxjs-docs.git (push)
If you have only origin
then please perform the below step
git remote add upstream git@github.com:ReactiveX/rxjs-docs.git
Then perform below steps
git checkout master
git pull --ff upstream master
git checkout 143-combineLatest-tip
git rebase master -i
git push -f
Also, please refer https://github.com/ReactiveX/rxjs-docs/blob/master/CONTRIBUTING.md
@nicolaisueper - Let me know if this help
@ashwin-sureshkumar Thanks a lot! I thought I should only rebase the commits inside this PR. Now rebased onto master.
@nicolaisueper - Thank you !
This is so great! Thank you @nicolaisueper and @ashwin-sureshkumar! 💯
Point out that
combineLatest
starts to emit when all sources have emitted at least once and a hint tostartWith
for a default first value