search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

chore(packages) Upgrade to Angular v5 #160

Closed feloy closed 6 years ago

feloy commented 6 years ago

Refs Issue #150

codecov-io commented 6 years ago

Codecov Report

Merging #160 into master will increase coverage by 2.56%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   88.46%   91.02%   +2.56%     
==========================================
  Files           7        7              
  Lines          78       78              
  Branches        7        5       -2     
==========================================
+ Hits           69       71       +2     
  Misses          6        6              
+ Partials        3        1       -2
Impacted Files Coverage Δ
src/app/operators/operators.component.ts 85.36% <0%> (+4.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a72064d...43d6289. Read the comment docs.

ashwin-sureshkumar commented 6 years ago

@feloy - Can we locked down exact version numbers of all the packages.

ashwin-sureshkumar commented 6 years ago

@feloy Thank you!

ashwin-sureshkumar commented 6 years ago

@btroncone @sumitarora - One more approval and I can merge this in.

btroncone commented 6 years ago

Do we want to make this 5.0.2 instead?

ladyleet commented 6 years ago

Thanks @feloy!

ladyleet commented 6 years ago

Oops sorry fat fingers on my phone :)