search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

adding beta warning #172

Closed necoline closed 6 years ago

rxjs-bot commented 6 years ago
Fails
:no_entry_sign: commit message does not follows conventional change log (2)
Warnings
:warning: :exclamation: Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

(2) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by :no_entry_sign: dangerJS

ladyleet commented 6 years ago

@necoline WOOHOO your first PR for RxJS docs!!!!!!

btroncone commented 6 years ago

Thanks! 👍

ashwin-sureshkumar commented 6 years ago

@necoline - Thanks for the PR. Just a small change in your commit message since it doesn't follow the commit message guidelines.

Contribution guidelines has the commit message guideline information

Let me know if you need any help.

ashwin-sureshkumar commented 6 years ago

@necoline - Just following up on this PR. Let me know if you need any help

ladyleet commented 6 years ago

@necoline woot! merged <3