search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

fix(browser): Add value to menu button #215

Closed knitcodemonkey closed 6 years ago

knitcodemonkey commented 6 years ago

Add value tag to menu button to fulfill a11y requirements. Add package-lock.json to gitignore.

none

rxjs-bot commented 6 years ago
Fails
:no_entry_sign: commit message does not follows conventional change log (2)
Warnings
:warning: :exclamation: Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

(2) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by :no_entry_sign: dangerJS