search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

fix(accessibility): Changed colors of links and operator header copy #217

Closed chrisdemars closed 6 years ago

chrisdemars commented 6 years ago

I changed the colors of the links to a darker blue and the operator header copy to white to fix color contrast errors.

codecov-io commented 6 years ago

Codecov Report

Merging #217 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files          10       10           
  Lines         149      149           
  Branches        7        7           
=======================================
  Hits          111      111           
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e6847e...0d9327a. Read the comment docs.

chrisdemars commented 6 years ago

Ooooh that is my fault. I thought I put the space in, sorry.

On Wed, Dec 20, 2017 at 2:25 PM, Gois notifications@github.com wrote:

@guilhermejcgois commented on this pull request.

In src/app/operators/_operator-theme.scss https://github.com/ReactiveX/rxjs-docs/pull/217#discussion_r158112630:

@@ -2,7 +2,7 @@

$operator-border: #f3f3f3; $operator-active: #62757f; -$link-color: #2196f3; +$link-color:#0a6fc2;

Not a big deal, but isn't better to keep the space between colon and #? Just a cosmetic point

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ReactiveX/rxjs-docs/pull/217#pullrequestreview-84869854, or mute the thread https://github.com/notifications/unsubscribe-auth/AGfAcqMQ-RKp4qI1nLqDJw8ZTzcJh6LMks5tCV4PgaJpZM4RIw5S .

guilhermejcgois commented 6 years ago

Ooooh that is my fault. I thought I put the space in, sorry.

Glad to help

chrisdemars commented 6 years ago

I put that fix in @guilhermejcgois

ashwin-sureshkumar commented 6 years ago

@chrisdemars - Nice job. Can you please squash your commits and push ? Thank you !

chrisdemars commented 6 years ago

I don't know how to squash commits @ashwin-sureshkumar. I have never had to do that before.

chrisdemars commented 6 years ago

Thanks for the merge