ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4

Apache License 2.0

160 stars 62 forks source link

docs(operators): add documentation for bufferTime #235

Closed DiedrikDM closed 6 years ago

DiedrikDM commented 6 years ago

add documentation for bufferTime to close #111

codecov-io commented 6 years ago

Codecov Report

Merging #235 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files          15       15           
  Lines         175      175           
  Branches        7        7           
=======================================
  Hits          135      135           
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a90120...ce87587. Read the comment docs.

ashwin-sureshkumar commented 6 years ago

@DiedrikDM - Thanks for the PR ! Just some few minor comments.

DiedrikDM commented 6 years ago

@ashwin-sureshkumar modified the PR to follow your requested changes. I went ahead and chose to use the map operator in the examples, as input for the bufferTime operator, so the click events are now only shown on the console with an X and Y coordinate.

ashwin-sureshkumar commented 6 years ago

@DiedrikDM - The jsbin link is still not updated with the new changes.

DiedrikDM commented 6 years ago

@ashwin-sureshkumar Well I guess that's why there's a review system at place >.< I added a link to the wrong snapshot (1 should be a 2) on jsbin. So sorry, I'll modify that as soon as possible!

ashwin-sureshkumar commented 6 years ago

@DiedrikDM - Not a problem at all.