ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4

Apache License 2.0

160 stars 62 forks source link

refactor(operators): update examples to pipeable operators with imports #237

Closed btroncone closed 6 years ago

btroncone commented 6 years ago

Updates all examples to use pipeable operators and adds proper imports.

rxjs-bot commented 6 years ago

	Warnings
:warning:	:exclamation: Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by :no_entry_sign: dangerJS

DiedrikDM commented 6 years ago

@btroncone You're running into the same issue as I did... You can modify the package.json to add the latest angular-cli version (1.6.5) to make the Travis build succeed. Maybe we should create a separate issue for that problem?

btroncone commented 6 years ago

@DiedrikDM Yeah, we need to update to latest versions of angular and material anyway, might as well include angluar/cli at the same time. I will send a PR in later if no one has gotten to it. 👍

ashwin-sureshkumar commented 6 years ago

@btroncone - There is a PR by @DiedrikDM which updates the packages which is still waiting for second approval. I can merge in, then you can rebase.

btroncone commented 6 years ago

@ashwin-sureshkumar Apologies for some of these misses, trying to mass update in comments is not an ideal scenario. Thanks for catching!

btroncone commented 6 years ago

@ashwin-sureshkumar All typos have been fixed. Once #243 is merged this should build properly.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5edd48f). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #237   +/-   ##
=========================================
  Coverage          ?   77.14%           
=========================================
  Files             ?       15           
  Lines             ?      175           
  Branches          ?        7           
=========================================
  Hits              ?      135           
  Misses            ?       40           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5edd48f...e890232. Read the comment docs.

ashwin-sureshkumar commented 6 years ago

@btroncone - Is it possible to squash your commits in this PR?