Open sumitarora opened 6 years ago
oh baby!
Warnings | |
---|---|
:warning: | :exclamation: Big PR (1) |
(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.
Generated by :no_entry_sign: dangerJS
:exclamation: No coverage uploaded for pull request base (
master@91a3918
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
Coverage ? 77.14%
=========================================
Files ? 15
Lines ? 175
Branches ? 7
=========================================
Hits ? 135
Misses ? 40
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 91a3918...57caa86. Read the comment docs.
Apparently no console? Do we need it for our documentation? I like your solution where we add it in the HTML, but our docs will need to change ofc...
@DiedrikDM yes for sure this is just a POC to see it would work in our case.
Look awesome, very exciting!
Check out the styling I had for the stackblitz embeds in the Angular / React examples branch. This will normalize the top and bottom colors for the example panes to match stackblitz colors. :)
Looks pretty awesome. Great job!
@DiedrikDM @sumitarora would y'all want an integrated console? Bc we're actually going to be rolling that out in mid-late March :)
@EricSimons That would be awesome! I also started converting my learnrxjs examples to stackblitz and that's the one thing I missed. Can't wait for this!
@EricSimons That would be awesome as I am currently modifying all examples to display output in HTML as all our examples used console.log
. I can leave them as it is yay!! :D
@EricSimons kicking some butt! :) we are so excited.
Hey all! Just wanted to let everyone know we're still on track for mid-late March release of the integrated console. We're actually porting chrome devtools to work inside of stackblitz for this, so it should end up being a very awesome & familiar debugging experience (which is also why it's taking a few weeks instead of a few days :)
@btroncone @sumitarora @ladyleet it's live! Take a peek:
We have a query param for setting the console height from 0-100% (see it in action here), will also be adding it to the SDK tomorrow and marking a new release π»
Would love to hear your thoughts!
Did initial POC of stackblitz implementation implemented on two operators http://localhost:4200/#/operators/concat and http://localhost:4200/#/operators/combineAll
@ashwin-sureshkumar @ladyleet @btroncone π