search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

Bug: Escape closes Sidebar #255

Closed niklas-wortmann closed 6 years ago

niklas-wortmann commented 6 years ago

Pressing the Escape key, closes the Sidebar, but you can't open it again

jsonberry commented 6 years ago

@JWO719 I was unable to reproduce this. Perhaps it was fixed, can you confirm?

Also, do you recall the browser you tested in?

niklas-wortmann commented 6 years ago

Hi I could reproduce it in Chrome. You just have to click on an operator and during focus you could hide the sidebar with escape. But this bug also occurs in firefox. I don't want to test it in IE but I'm quite sure there is this bug also :D

jsonberry commented 6 years ago

Gotcha! Okay I was able to reproduce now. Thanks!

knitcodemonkey commented 6 years ago

Pressing escape to close the sidebar was intentional. We wanted the ability to skip the menu, for accessibility reasons, after you selected the option you desired. You can open it up, again, by going to the menu and selecting operators.

The bug that does still exist is that on mobile, selecting an operator doesn't close the menu. You can press escape to close it manually, but it would be nice for it to automatically close as well. I've added a bug for that. #277

jsonberry commented 6 years ago

@knittingcodemonkey Cool, that makes sense. Glad to hear it was intentional.

As the UX stands right now:

As a user
Given I am on an inner operator page
And it is not an operator at the top of the menu
And the sidenav is closed
When I select the button to open the sidenav
And I select operators
I start at the top of the list of operators

Would it be better if...

When I select the button to open the sidenav
And I select operators
I start at the place I was at in the list of operators
knitcodemonkey commented 6 years ago

I do like the option of setting the focus, when you open the menu, to the page and/or operator on which you are currently located.

The bug for not closing the side menu on mobile sizes is #277. I just added it.

jsonberry commented 6 years ago

Thanks for making #277 I'll put some :eyes: on it

knitcodemonkey commented 6 years ago

Thank you for your help, and your contributions! You're doing great work.

jsonberry commented 6 years ago

Per the discussion here @JWO719 , can we close this issue?

I've opened #278 to capture UX improvements when reopening the sidenav.

niklas-wortmann commented 6 years ago

closing due to #277