ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4

Apache License 2.0

160 stars 62 forks source link

feat($browser): Added support for Server Side Rendering (Angular Univ… #262

Closed bojidaryovchev closed 6 years ago

bojidaryovchev commented 6 years ago

…ersal)

Added support for Server Side Rendering (Angular Universal). The major difference is that now, upon build, the browser code goes to dist/browser and the server code goes to dist/server, respectively. However, its up to the backend team to implement SSR on the server.

The only breaking change is the directory structure: browser code used to go in /dist, now there are two folders - /dist/browser and /dist/server

codecov-io commented 6 years ago

Codecov Report

Merging #262 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files          15       15           
  Lines         175      175           
  Branches        7        7           
=======================================
  Hits          135      135           
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 621c41d...b9b857e. Read the comment docs.

niklas-wortmann commented 6 years ago

Is there any difference to #173?

bojidaryovchev commented 6 years ago

Well, as I see, #173 has additional changes which are not really necessary given the fact we only deal with the front end.. So I think this one is cleaner and doesn't deal with things we are not supposed to be dealing with

niklas-wortmann commented 6 years ago

To be honest I don't know how to proceed, because @feloy already did a lot of work with his pr. @ashwin-sureshkumar , @ladyleet , @sumitarora , @btroncone any suggestions how to proceed?

rxjs-bot commented 6 years ago

	Fails
:no_entry_sign:	commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by :no_entry_sign: dangerJS

ladyleet commented 6 years ago

Reviewing with team - will get back soon to this.

bojidaryovchev commented 6 years ago

nevermind, I closed it, apologies