search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

feat(operators): add searchbar #264

Closed niklas-wortmann closed 6 years ago

niklas-wortmann commented 6 years ago

closes #254

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@91a3918). Click here to learn what that means. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage          ?   79.64%           
=========================================
  Files             ?       17           
  Lines             ?      226           
  Branches          ?       10           
=========================================
  Hits              ?      180           
  Misses            ?       44           
  Partials          ?        2
Impacted Files Coverage Δ
src/app/operators/operators.component.ts 88.46% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91a3918...141c3e1. Read the comment docs.

knitcodemonkey commented 6 years ago

It looks like there is a merge conflict here. Can you resolve that?

niklas-wortmann commented 6 years ago

thank you for your review. To be honest I would have expected several issues, but I'm totally fine with it :D

ashwin-sureshkumar commented 6 years ago

@JWO719 Also, while you filter down there is an empty space created for each of the category group that doesn't have any operators for the filtered value.

screen shot 2018-02-20 at 9 09 33 am

btroncone commented 6 years ago

Just a style preference, but I would consider removing the floating placeholder for the search bar. I'm also not sure if we need the bottom line or if we could use the below header to frame it. What do you all think?

image

jsonberry commented 6 years ago

@btroncone agreed on removal of floating placeholder and bottom line.

A UX concern I have is that the user is required to delete characters from search in order to reset the list. I think there should be an automatic clearing of the search if an operator is selected, and/or a reset button should be available.

Perhaps we could...