search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

feat(i18n): add dynamic import module for translation #274

Closed IraErshova closed 6 years ago

IraErshova commented 6 years ago

Add dymanic import for translation Change approach in the operator's initialization, when there is no transaltion Update unit test

PR depends on PR #270 (https://github.com/ReactiveX/rxjs-docs/pull/270)

rxjs-bot commented 6 years ago
Warnings
:warning: :exclamation: Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by :no_entry_sign: dangerJS

codecov-io commented 6 years ago

Codecov Report

Merging #274 into master will increase coverage by 0.49%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage      90%   90.49%   +0.49%     
==========================================
  Files         103      115      +12     
  Lines         410      442      +32     
  Branches       10       10              
==========================================
+ Hits          369      400      +31     
  Misses         40       40              
- Partials        1        2       +1
Impacted Files Coverage Δ
src/i18n/ru/combination/combineLatest.ts 100% <100%> (ø)
src/i18n/ru/filtering/debounce.ts 100% <100%> (ø)
src/i18n/ru/filtering/skipWhile.ts 100% <100%> (ø)
src/i18n/ru/transformation/partition.ts 100% <100%> (ø)
src/i18n/ru/creation/empty.ts 100% <100%> (ø)
src/i18n/ru/index.ts 100% <100%> (ø) :arrow_up:
src/app/operators/operators.component.ts 88.09% <100%> (-4.77%) :arrow_down:
src/i18n/ru/filtering/skip.ts 100% <100%> (ø)
src/app/core/services/operators.service.ts 100% <100%> (+4.34%) :arrow_up:
src/i18n/ru/filtering/index.ts 100% <100%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfaeff8...ce1d22f. Read the comment docs.