search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

fix(operators): disable esc key closing of nested operator sidenav #275

Closed jsonberry closed 6 years ago

jsonberry commented 6 years ago

Only disables close via esc when larger than a small screen

Closes Issue #255 Bug: Escape closes Sidebar

jsonberry commented 6 years ago

@JWO719 could you review please?

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@91a3918). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #275   +/-   ##
========================================
  Coverage          ?   79.9%           
========================================
  Files             ?      17           
  Lines             ?     214           
  Branches          ?       9           
========================================
  Hits              ?     171           
  Misses            ?      41           
  Partials          ?       2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91a3918...0c28e3e. Read the comment docs.

jsonberry commented 6 years ago

Closing this PR and finishing the UX discussion brought up in #255

@knittingcodemonkey brought up that closing of the nested sidenav is intentional.