search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

Bug: On mobile sizes, close the menu automatically once an operator is selected. #277

Closed knitcodemonkey closed 6 years ago

knitcodemonkey commented 6 years ago

At the moment, when you select an operator, the side menu doesn't close. You can close it by pressing escape, but the menu should close by default. We do want to continue to show the side menu at larger sizes that can support the width.

jsonberry commented 6 years ago

I wonder if there's something we could do like a "skip to main" when a user selects an operator sidenav item, instead of just closing the menu.

Our main concern for a11y is to get the user to the main content after making the selection, right?

knitcodemonkey commented 6 years ago

Yes, the purpose is to keep them from having to walk through the entire menu just to get to the content. Once they select an option, it should re-focus directly on the main data.

On mobile sizes, they shouldn't have to select an item on the sub-menu AND select to skip to main to get to the content. The menu should close, and focus them on the main content.

On desktop sizes, it should just focus on the content. The escape button keeps them from having to walk, backwards, through the entire sub-menu, to get to the menu button so they can switch to another main page like the company page, or the future getting started guide.

jsonberry commented 6 years ago

Cool, makes sense, thanks! 👍

ladyleet commented 6 years ago

@jsonberry i love seeing you getting involved!