search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

refactor: minor changes #279

Closed jotatoledo closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@91a3918). Click here to learn what that means. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage          ?   79.62%           
=========================================
  Files             ?       17           
  Lines             ?      216           
  Branches          ?        9           
=========================================
  Hits              ?      172           
  Misses            ?       42           
  Partials          ?        2
Impacted Files Coverage Δ
src/app/companies/company.service.ts 85.71% <ø> (ø)
...pp/team/social-sharing/social-sharing.component.ts 100% <100%> (ø)
src/app/team/member.component.ts 100% <100%> (ø)
src/app/team/team.service.ts 77.77% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91a3918...d553430. Read the comment docs.

rxjs-bot commented 6 years ago
Fails
:no_entry_sign: commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by :no_entry_sign: dangerJS

jotatoledo commented 6 years ago

Ill redo, as I didnt respected the contributing guidelines :smile: