search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
160 stars 62 forks source link

fix(operators): Autoclose sidenav on operator selection in sm… #280

Closed jotatoledo closed 6 years ago

jotatoledo commented 6 years ago

…all screens

Close the sidenav after an operator is selected if on small screen. Keep track of screen size through observables. Change detection strategy setted to OnPush

Closes #277

codecov-io commented 6 years ago

Codecov Report

Merging #280 into master will increase coverage by 0.22%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   90.49%   90.72%   +0.22%     
==========================================
  Files         115      115              
  Lines         442      442              
  Branches       10        9       -1     
==========================================
+ Hits          400      401       +1     
  Misses         40       40              
+ Partials        2        1       -1
Impacted Files Coverage Δ
src/app/operators/operators.component.ts 90.47% <100%> (+2.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b103d...ec1f867. Read the comment docs.

sumitarora commented 6 years ago

@jotatoledo Please resolve conflicts.