ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4

Apache License 2.0

161 stars 63 forks source link

refactor(operators): presentation components #289

Closed jotatoledo closed 6 years ago

jotatoledo commented 6 years ago

Set changeDetection to OnPush for dumb components
Add explicit return types to getters in OperatorComponent
Add explicit return type to SafeUrlPipe

codecov-io commented 6 years ago

Codecov Report

Merging #289 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8a1f7c...95a17fa. Read the comment docs.

sumitarora commented 6 years ago

@jotatoledo Please resolve conflicts.

ladyleet commented 6 years ago

@jotatoledo hi! have you had time to resolve these conflicts?

jotatoledo commented 6 years ago

Hey sorry for the delay, totally forgot to update the PR. Looks like a WIP commit got mixed on my local, I think Ill have to revert the commit.

ashwin-sureshkumar commented 6 years ago

@jotatoledo - Thanks for the PR, nice work.

ladyleet commented 6 years ago

Thx @ashwin-sureshkumar! Also thx @jotatoledo for contributing!