search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
161 stars 63 forks source link

docs(operators): add documentation for windowWhen #291

Open hardikpthv opened 6 years ago

hardikpthv commented 6 years ago

Closes: #127

codecov-io commented 6 years ago

Codecov Report

Merging #291 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         116      116           
  Lines         445      445           
  Branches        9        9           
=======================================
  Hits          404      404           
  Misses         40       40           
  Partials        1        1
Impacted Files Coverage Δ
src/operator-docs/transformation/windowWhen.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4097607...4bca2d1. Read the comment docs.

niklas-wortmann commented 6 years ago

@hardikpthv I think after the changes requested by ashwin, this pr can be merged. Do you need any help with this one?

hardikpthv commented 6 years ago

Sorry, @JWO719 got busy these days, so couldn't make proposed changes. Let me check this one. I will let you know in case of help. :)

hardikpthv commented 6 years ago

@JWO719, @ashwin-sureshkumar requested changes are made do let me know if anything else is required.