ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
161 stars 63 forks source link

docs(Observable): add documentation for interval #296

Closed cschomer closed 1 year ago

cschomer commented 6 years ago

Add docs for operator : creation - interval

Close #80

niklas-wortmann commented 6 years ago

Could you change your commit messages. There are several :, these make travis break. If you need any help, just inform me. Thanks for your work!!!

cschomer commented 6 years ago

Yes sorry about that, should be corrected and passing now.

codecov-io commented 6 years ago

Codecov Report

Merging #296 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2
Impacted Files Coverage Δ
src/operator-docs/creation/interval.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b103d...073aed5. Read the comment docs.

ladyleet commented 6 years ago

@cschomer have time to make these changes yet? we'd love to merge!

cschomer commented 6 years ago

@ladyleet Hi I checked in 2 commits for the requested changes, are those not showing up? I think with those two that should address the two requested changes.

commit ea9c472d97e6c7b0f00feabc55bed642ab0781d1

ashwin-sureshkumar commented 6 years ago

@cschomer - Thanks for the PR.

Please use Close #<issue-number> in your future commits in the description. This will auto-close the issue once the PR is merged in.

For this one, we can manually close the issue.