Closed saiprasad2595 closed 6 years ago
Thanks @ashwin-sureshkumar for review.Can you tell me where i am doing wrong in case of commit message as it is my first PR. I am using "fix (fix): open external pages in new tab"
Merging #297 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #297 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 115 115
Lines 442 442
Branches 10 10
=======================================
Hits 400 400
Misses 40 40
Partials 2 2
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3dc2401...90660cd. Read the comment docs.
@saiprasad2595 - I fixed your commit and squashed your commits into one commit. (note: there were couple of weird merge commits)
Few things to be noted,
Commit message should be <type>(<scope>): <subject>
- so no space between type and scope bracket.
Please add Close #<issue-no>
in the description. This will auto close the issue once the PR is merged in. This helps the change log as well efficiency in not closing issues manually.
Your initial commit message did not meet guidelines, so that needed to be fixed as well.
Again, nice work ! Let the PRs flow.
cc @ladyleet
@JWO719 or @ladyleet - Could I get a second approval on this please ?
Thanx a ton @ashwin-sureshkumar . Will sure keep those points in my next commits.
Close #258