ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
161 stars 63 forks source link

fix (accessibility): change open external pages in new tab #297

Closed saiprasad2595 closed 6 years ago

saiprasad2595 commented 6 years ago

Close #258

saiprasad2595 commented 6 years ago

Thanks @ashwin-sureshkumar for review.Can you tell me where i am doing wrong in case of commit message as it is my first PR. I am using "fix (fix): open external pages in new tab"

codecov-io commented 6 years ago

Codecov Report

Merging #297 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dc2401...90660cd. Read the comment docs.

ashwin-sureshkumar commented 6 years ago

@saiprasad2595 - I fixed your commit and squashed your commits into one commit. (note: there were couple of weird merge commits)

Few things to be noted,

  1. Commit message should be <type>(<scope>): <subject> - so no space between type and scope bracket.

  2. Please add Close #<issue-no> in the description. This will auto close the issue once the PR is merged in. This helps the change log as well efficiency in not closing issues manually.

  3. Your initial commit message did not meet guidelines, so that needed to be fixed as well.

Again, nice work ! Let the PRs flow.

cc @ladyleet

ashwin-sureshkumar commented 6 years ago

@JWO719 or @ladyleet - Could I get a second approval on this please ?

saiprasad2595 commented 6 years ago

Thanx a ton @ashwin-sureshkumar . Will sure keep those points in my next commits.