ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
161 stars 63 forks source link

docs(observables): Add docs for operator : creation - timer #299

Closed cschomer closed 6 years ago

cschomer commented 6 years ago

Add docs for operator : creation - timer #84

codecov-io commented 6 years ago

Codecov Report

Merging #299 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2
Impacted Files Coverage Δ
src/operator-docs/creation/timer.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 340973d...2eb5a7a. Read the comment docs.

niklas-wortmann commented 6 years ago

And could you add the issue number in the comment at top, so that the issue is closed when the pr is merged.

ladyleet commented 6 years ago

@cschomer can you resolve conflicts too? @JWO719 what do you think of the new changes?

ladyleet commented 6 years ago

Thx @ashwin-sureshkumar! :) @cschomer just rebase and we can merge

niklas-wortmann commented 6 years ago

Woop Woop, Great job !!