ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4

Apache License 2.0

161 stars 63 forks source link

docs(home): add content to home page #304

Closed yashints closed 6 years ago

yashints commented 6 years ago

added content to main page: installation guide #17

yashints commented 6 years ago

@JWO719 I am following the guidelines (header / body) with a line break, should I just enter the header? which white space is causing the failure?

niklas-wortmann commented 6 years ago

the commit message should be in format: (): And I think main page and installation causes the failing travis build. Maybe replace it with 'instructions" or something like that.

codecov-io commented 6 years ago

Codecov Report

Merging #304 into master will increase coverage by 0.06%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   90.72%   90.78%   +0.06%     
==========================================
  Files         115      116       +1     
  Lines         442      445       +3     
  Branches        9        9              
==========================================
+ Hits          401      404       +3     
  Misses         40       40              
  Partials        1        1

Impacted Files	Coverage Δ
src/app/app.component.ts	`65.38% <ø> (ø)`	:arrow_up:
.../components/installation/installation.component.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8b93a5...d3f4311. Read the comment docs.

yashints commented 6 years ago

thanks for the tips @JWO719

ashwin-sureshkumar commented 6 years ago

@yashints My bad. Yeah if you could move this into the template would be great

yashints commented 6 years ago

@ashwin-sureshkumar done

ashwin-sureshkumar commented 6 years ago

@yashints - nice work !! Thanks for the PR !!! :)

ashwin-sureshkumar commented 6 years ago

@JWO719 can you review and approve please

niklas-wortmann commented 6 years ago

Yeah of course. Sorry for being that late. I will have some time for a review tomorrow and give some feedback

niklas-wortmann commented 6 years ago

WOOP WOOP @yashints PR merged. Well Done!

yashints commented 6 years ago

Thanks @JWO719 and @ashwin-sureshkumar and especially @ladyleet