search

ReactiveX / rxjs-docs

The home for new work on the new RxJS docs (RxJS v 5 and up). New to this space? Say hi here: https://github.com/ReactiveX/rxjs-docs/issues/24. Want to find out what's up? We're chatting here. https://github.com/ReactiveX/rxjs-docs/issues/4
Apache License 2.0
161 stars 63 forks source link

Inaccurate description of scan behavior in introduction #329

Open jonahbron opened 6 years ago

jonahbron commented 6 years ago

In the Purity section of the Introduction, the last paragraph describes scan() working "just like reduce for arrays".

https://rxjs-dev.firebaseapp.com/guide/overview#purity

It is similar, but not identical, since scan still emits every cumulative value, while reduce does not. I tried to search through the source code and the language files with which to make a PR, but I can't find where this text lives. Can someone point me in the right direction so I can propose alternate wording?

shaunlebron commented 6 years ago

The introduction markdown file is in another repo, presumably linked to as a submodule under rxjs-docs/ in this repo:

https://github.com/ReactiveX/rxjs/blob/master/doc/introduction.md#purity

I'm guessing we have to make PRs in that repo instead?

niklas-wortmann commented 6 years ago

Sorry for the confusion on that. We switched to the the rxjs repo. If you need help with that, just ping me. Sorry for the confusion. This repository is just used to transfer the awesome content already made.