ReactiveX / rxjs-tslint

TSLint rules targeting RxJS
MIT License
309 stars 41 forks source link

Migrating TsLint to EsLint #67

Closed break7533 closed 3 years ago

break7533 commented 5 years ago

Will the migration affect the way this plugin works?

For the moment we create the rules in a tslint.json file. While migrating to ESlint this will disappear. Is it possible to add the rule to an eslint.json file and keep the plugin alive or will it require more work?

smorimoto commented 4 years ago

+1

lorenzodallavecchia commented 3 years ago

Did someone ever try using these rules with ESLint? In my project, I use ESLint exclusively since TSLint is now deprecated.

break7533 commented 3 years ago

Yeah, in the meanwhile in the projects I work on we just moved all the rules to the eslint.json file and everything works dandy

lorenzodallavecchia commented 3 years ago

@break7533 do you have an example of how to use rxjs-tslint with ESLint? I'm trying to configure the rules in eslintrc.js but it always errors out saying that the rule definition was not found.

break7533 commented 3 years ago

We are now using eslint-plugin-rxjs

And on .eslintrc.json we just add the rules, example

"rules": {
        "rxjs/no-internal": "error",
        "rxjs/no-async-subscribe": "error",
        "rxjs/no-nested-subscribe": "error",
        "rxjs/no-unbound-methods": "error",
}
lorenzodallavecchia commented 3 years ago

Yeah, I have tried eslint-plugin-rxjs. The bad part is that it does not have a rule for detecting usages of non-pipeable operators. I guess I'll have to live with that.