fix: tslint and typescript should not be dependencies

ReactiveX / rxjs-tslint

TSLint rules targeting RxJS

MIT License

309 stars 41 forks source link

Closed JounQin closed 4 years ago

JounQin commented 4 years ago

@mgechev They have already been declared as peerDependencies.

Listing them as dependencies resolve a lot of issues like following when upgrading deps:

error An unexpected error occurred: "could not find a copy of typescript to link in ...\\node_modules\\rxjs-tslint\\node_modules".

JounQin commented 4 years ago

@mgechev Please, help to review...

JounQin commented 4 years ago

So disappointed about this. I'll publish my own fork then.

malthoff commented 4 years ago

Why is this fix not merged? We are having the exact same problems. Please merge

JounQin commented 4 years ago

I decided to republish it as @rxts/rxjs-tslint at https://github.com/rx-ts/rxjs-tslint.