ReactiveX / rxjs

A reactive programming library for JavaScript
https://rxjs.dev
Apache License 2.0
30.56k stars 3k forks source link

Add Code of Conduct #101

Closed benlesh closed 8 years ago

benlesh commented 9 years ago

It's paramount that we make sure this repository is inclusive. I don't want to turn off potentially brilliant contributions because they don't feel comfortable. I know the contributors thus far and I really doubt we will ever have a problem. Still, this repository is open to public contribution, so quality might vary.

As such, I think it's really important we have a Code of Conduct and that we enforce that Code of Conduct.

http://contributor-covenant.org was recommended, and it looks pretty solid.

mattpodwysocki commented 9 years ago

@blesh please don't reinvent the wheel. RxJS already had one. Please use that: https://github.com/Reactive-Extensions/RxJS/tree/master/doc/contributing#code-of-conduct

benlesh commented 9 years ago

@mattpodwysocki I didn't reinvent anything. The CoC I've added was pre-existing and popular. I honestly didn't see the CoC in RxJS, I didn't think to look in the Contribution Guidelines. Is there something drastically wrong with the one I put up?

mattpodwysocki commented 9 years ago

@blesh there's no need to change the one we already had, that's my point. RxJS has had for quite some time a CoC. Why add/change what we already had?

benlesh commented 9 years ago

Why add/change what we already had?

I honestly didn't see the CoC in RxJS, I didn't think to look in the Contribution Guidelines.

Since there's one in there now, I could change it again to whatever you have, then notify @CarolineAda that we won't be using her CoC. Then I'll need to submit a PR to that repo, to have our name removed from the list.

I actually liked us being part of a more unified effort toward equality in this arena. Seems like unnecessary effort to change again if there is nothing wrong with the one we have in place now, though.

Regardless, I think it should be it's own, all-caps file in the root directory, and linked at the top of our README.

benlesh commented 9 years ago

@mattpodwysocki We will definitely reuse everything we can from the RxJS Contribution Guidelines. Is there anything else like that you feel we should pay special attention to?

mattpodwysocki commented 9 years ago

@blesh Please look or ask before doing this in the future as we had things already defined. The CoC was very precise in its language as I put a bit of time and effort into this and to have it just chucked out unnerves me. That's why I'd rather have it undone. If you have any suggestions to change the CoC, make that in my repository, not this one first without consulting me.

jeremymwells commented 9 years ago

I don't see how utilizing a pre-existing CoC is reinventing the wheel. In my estimation, contributor covenant seems more aligned with community guidelines as regards CoC because it is a community-endorsed set of guidelines for CoC.

jamiebuilds commented 8 years ago

The Contributor Covenant is an open and peer reviewed document that is maintained by people of many backgrounds and has been adopted by dozens of major projects.

As a member of the LGBT community and as a person who cares very much about diversity, especially in technology, I strongly recommend keeping the Contributor Covenant.

:+1: to close as resolved.