search

ReactiveX / rxjs

A reactive programming library for JavaScript
https://rxjs.dev
Apache License 2.0
30.7k stars 3k forks source link

repeatWhen missing? #1456

Closed ronag closed 7 years ago

ronag commented 8 years ago

https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/repeatwhen.md

kwonoj commented 8 years ago

As migration guide states, not all of operators are migrated into RxJS5 yet. (just noticed retryWhen is missing in table though..)

luisgabriel commented 8 years ago

I think this operator was added recently to RxJS4: https://github.com/Reactive-Extensions/RxJS/commit/871f6d31315366e62a8e372b68e29fed1e5b398d

kwonoj commented 8 years ago

Ah, that's reason migration guide does not include it yet maybe? :)

mattpodwysocki commented 8 years ago

@kwonoj I think we need to update the table, especially for variant overloads such as .catch is missing the .catch(...Observables) overload

kwonoj commented 8 years ago

@mattpodwysocki Yes, current migration document are somewhat fall behind compare to current status. Need to be updated.

benlesh commented 8 years ago

@mattpodwysocki since catch(...observables) will be wildly different in it's internals from catch(fn) we should probably follow the suit of map/mapTo and implement it separately. catch performs pretty well right now. What do you think? I must say that catchTo seems ugly, maybe catchWith or something? Or even errorTo, I dunno?

Thoughts?

benlesh commented 7 years ago

repeatWhen exists now.

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.