ReactiveX / rxjs

A reactive programming library for JavaScript
https://rxjs.dev
Apache License 2.0
30.8k stars 3k forks source link

Missing image for forkJoin and skipLast #3917

Closed gabrielnemeth closed 6 years ago

gabrielnemeth commented 6 years ago

Documentation Related To Component:

forkJoin skipLast

Please check those that apply

Description Of The Issue

There are missing 2 marble diagrams for forkJoin and skipLast. http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html#static-method-forkJoin http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html#instance-method-skipLast

missing

ladyleet commented 6 years ago

Ccing in @JWO719 - was this included in the new documentation at all? @gabrielnemeth if you'd like to submit a PR for this as well, feel free to! :)

niklas-wortmann commented 6 years ago

I am really not sure. But I'll check that. Thanks for pointing

martinsik commented 6 years ago

I checked docs_app in the current master and both operators do have images.

screen shot 2018-07-14 at 13 04 46 screen shot 2018-07-14 at 13 05 15

niklas-wortmann commented 6 years ago

thanks @martinsik for checking!