Migration guide: Testing asynchronous error handling

[molily]

Documentation Related To Component:

https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md

Please check those that apply

• [ ] typo
• [ ] documentation doesn't exist
• [X] documentation needs clarification
• [X] error(s) in example
• [ ] needs example

Description Of The Issue

Regarding this example code:

it('should emit an error on subscription', (done) => {
  source$.subscribe({
    error(err) {
      expect(err.message).toEqual('some message');
    }
  });
});

The done function is mentioned but not used. It should be called at least:

it('should emit an error on subscription', (done) => {
  source$.subscribe({
    error(err) {
      expect(err.message).toEqual('some message');
      done();
    }
  });
});

This would work, but there is still the problem that this test times out instead of failing instantly when the Observable emits a value instead of throwing an error.

In Jasmine, something like this would be better, wouldn’t it?

it('should emit an error on subscription', (done) => {
  source$.subscribe(
    done.fail,
    (err) => {
      expect(err.message).toEqual('some message');
      done();
    }
  });
});

[BioPhoton]

Due to the creation date and missing responses for so long, I assume we can close this one. @cartant please let me know if I'm wrong

[cartant]

@biophoton If the problem is still there and hasn't been addressed, we should fix it. The lack of responses should just been seen as people being busy with other, higher-prioriity tasks, that's all.

[BioPhoton]

Thx @cartant!

Just to make it clear, my intention here is not to put pressure in it. What I try is find old issues that could get closed.

I will consider your answer in further comments! 🙏🙏🙏❤️