search

ReactiveX / rxjs

A reactive programming library for JavaScript
https://rxjs.dev
Apache License 2.0
30.8k stars 3k forks source link

forkjoin marbel diagram is wrong. #5416

Closed its-dibo closed 2 years ago

its-dibo commented 4 years ago

in forkJoin doc, the documentation says that the output observable emmits values in the same order of the input observables.

but in the attached marbel diagram, it dosen't. the output value is (e ,4 ,j) i.e: values emitted by obs1, obs3, obs2 (not obs1, obs2, obs3)

the expected result is: (e, j, 4) and not (e, 4, j)

image

sijusamson commented 4 years ago

@cartant is anyone assigned for this ?

cartant commented 4 years ago

@sijusamson No, but I doubt this can be fixed ATM because the marble diagram generation is currently being changed.

sijusamson commented 4 years ago

So do i need to work on this ?

cartant commented 4 years ago

@sijusamson see the links in this comment and the PR in which it was made. The marble diagram generation is being completely replaced, so I don't think there's anything that you can do, ATM. However, if you want to acquaint yourself with Swirly - see #5019 - it's highly likely that you'll be able to help with the generation of the new diagrams soon, if that's something you'd be interested in. If that is the case, keep an eye on #5422.

jakovljevic-mladen commented 2 years ago

Closing as fixed in #4940.