search

ReactiveX / rxjs

A reactive programming library for JavaScript
https://rxjs.dev
Apache License 2.0
30.7k stars 3k forks source link

Browser support #733

Closed staltz closed 8 years ago

staltz commented 8 years ago

What is the "lowest common denominator" that RxJS 5 will target?

Do we support only ES6? Do we support ES5?

These questions came up when I was working on getting coverage for #732, and noticed how in Node 4.2.1 the code related to polyfilling ArrayIterator and StringIterator is never reached because of course, those exist already in Node 4.2.1.

Should we run tests using node v0.10.x? I tried that and many tests failed because of missing Promise etc.

kwonoj commented 8 years ago

Think ES5 need to be supported. Not sure about node - RxJS4 supports node 0.4+ but node has been updated quite amount - maybe support lowest stable version?

benlesh commented 8 years ago

I think it's just:

Browser support: IE9+ Node Support: 0.12+

Should we run tests using node v0.10.x? I tried that and many tests failed because of missing Promise etc.

Promise is being injected in those tests now for just that reason, I believe.

benlesh commented 8 years ago

Really until we have these tests running in something like Karma, testing in multiple browsers is going to be difficult. Also, there are a lot of CI tools that integrate with Travis that will test against multiple browsers and platforms, we should definitely look into that.

Also, if we do that, we can use a library that polyfills Promise (I think Bluebird does this).

benlesh commented 8 years ago

I'm going to close this in favor of #998.

We're supporting IE9+, Node 0.12+, and as many modern mobile browsers as we can test.

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.