search

ReadAlongs / Studio-Web-archived

ReadAlong Studio Web Interface
Other
2 stars 2 forks source link

chore(deps): bump Angular to 14.2 from 14.0 to address several CVEs #19

Closed joanise closed 1 year ago

joanise commented 1 year ago

These Dependabot alerts are all fixed by upgrading Angular to 14.2 and re-creating package-lock.json from scratch:

Tested on my machine with the automated test suite and manual testing.

CI passes too, on Node 14, 16 and 18.

joanise commented 1 year ago

@roedoejet @dhdaines @deltork This PR will require rerunning npm install when you update. But Angular 14.2 seems to update a bunch of packages for CVEs without changing any functionality. I've already moved Web-Component/packages/angular-component to Angular 14.2 since it is not in active use yet, but I want to give you a warning before updating this one, via this PR.

dhdaines commented 1 year ago

This seems good to me! Thanks for the unit test example!

joanise commented 1 year ago

@dhdaines Thanks! Ready to merge, then?

dhdaines commented 1 year ago

@dhdaines Thanks! Ready to merge, then?

No problem for me, merge when you're ready (and see Aidan's comments above)

joanise commented 1 year ago

@roedoejet updated and ready for re-reviewing. md+: image md: image sm-: image

joanise commented 1 year ago

And, for the record, I hate HTML, even in 2022 with all the frameworks and libraries. All this formatting nonsense, half of it not working at any given time, and never the same half from one day to the next. Bleh.

dhdaines commented 1 year ago

And, for the record, I hate HTML, even in 2022 with all the frameworks and libraries. All this formatting nonsense, half of it not working at any given time, and never the same half from one day to the next. Bleh.

It's really CSS that's the problem... decades later you still can't reliably do certain types of layouts that are easy to achieve with tables, and the whole point of CSS layouts was supposed to be to avoid using markup for presentation purposes...

joanise commented 1 year ago

And, for the record, I hate HTML, even in 2022 with all the frameworks and libraries. All this formatting nonsense, half of it not working at any given time, and never the same half from one day to the next. Bleh.

It's really CSS that's the problem... decades later you still can't reliably do certain types of layouts that are easy to achieve with tables, and the whole point of CSS layouts was supposed to be to avoid using markup for presentation purposes...

That's a fair point, all the stuff I'm fighting with is either classes which trigger css, or style="" which is just more css inlined. In the Coursera course too, I always find it annoying how to instructor adds this and that class and you're just supposed to know why. I have to experiment quite a bit to make sense of stuff.

Things like bootstrap or fxFlex layouts make things easier, for sure, but there just continue to be annoying corner cases where I feel the code is fighting me!