search

ReadAlongs / Studio-Web-archived

ReadAlong Studio Web Interface
Other
2 stars 2 forks source link

Update to SoundSwallower 0.6.0 #42

Closed dhdaines closed 1 year ago

dhdaines commented 1 year ago

Allows us to reduce, but sadly not eliminate, custom webpack configuration, because webpack's default behaviour is fine but Angular overrides it internally with something that doesn't work at all: https://github.com/angular/angular-cli/issues/24617

dhdaines commented 1 year ago

Ah, actually it would probably be good to go to soundswallower 0.6.1, as there is a small problem in 0.6.0 (which doesn't seem to necessarily cause a failure all the time, not sure why): https://github.com/emscripten-core/emscripten/issues/18610

dhdaines commented 1 year ago

So also - there are two possible solutions - in the long run we may want to explicitly include the WASM in assets and disable entirely import.meta.url parsing by webpack, since this matches what Angular+esbuild will do (even though I consider it to be totally wrong because WASM is not an "asset" but part of the code), but that runs into an Angular bug which breaks testing, so this is the best way to go for the moment.

joanise commented 1 year ago

I'm going to trust your judgement on all that. I saw a long conversation between you and Aidan about that, but I have not taken the time to understand it yet.